Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apiextensions] Remove presence check for map before delete in PrepareForCreate #92516

Merged
merged 1 commit into from
Jul 12, 2020
Merged

[apiextensions] Remove presence check for map before delete in PrepareForCreate #92516

merged 1 commit into from
Jul 12, 2020

Conversation

gaurav1086
Copy link
Contributor

Signed-off-by: Gaurav Singh gaurav1086@gmail.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Remove the nil check before delete in map.
Which issue(s) this PR fixes:

Fixes #
N/A
Special notes for your reviewer:
Minor cleanup.
Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@gaurav1086
[apiextensions] Remove nil check for map in PrepareForCreate
c96446a 
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 25, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @gaurav1086. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 25, 2020
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 25, 2020
@gaurav1086 gaurav1086 changed the title [apiextensions] Remove nil check for map in PrepareForCreate [apiextensions] Remove nil check for map before delete in PrepareForCreate Jun 25, 2020
@fedebongio
Copy link
Contributor

/assign @jiahuif

@jiahuif
Copy link
Member

jiahuif commented Jun 25, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2020
@gaurav1086
Copy link
Contributor Author

/retest

@gaurav1086
Copy link
Contributor Author

/test pull-kubernetes-integration

@jiahuif
Copy link
Member

jiahuif commented Jun 26, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2020
@jiahuif
Copy link
Member

jiahuif commented Jun 30, 2020

/assign @deads2k mind approving this?

logicalhan
logicalhan approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@lavalamp lavalamp changed the title [apiextensions] Remove nil check for map before delete in PrepareForCreate [apiextensions] Remove presence check for map before delete in PrepareForCreate Jul 9, 2020
@lavalamp
Copy link
Member

lavalamp commented Jul 9, 2020

/approve

(I changed the title because this is not actually nil check)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaurav1086, jiahuif, lavalamp, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2020
@spiffxp spiffxp added this to the v1.19 milestone Jul 9, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

5 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@joelsmith
Copy link
Contributor

/retest

1 similar comment
@joelsmith
Copy link
Contributor

/retest

@gaurav1086
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-100-performance

@joelsmith
Copy link
Contributor

/retest

1 similar comment
@joelsmith
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3486f9f into kubernetes:master Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@logicalhan logicalhan

@jiahuif jiahuif

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@gaurav1086 @k8s-ci-robot @fedebongio @jiahuif @lavalamp @fejta-bot @joelsmith @logicalhan @spiffxp